-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add v2 Proto definitions #5415
Add v2 Proto definitions #5415
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5415 +/- ##
==========================================
- Coverage 71.39% 71.39% -0.01%
==========================================
Files 399 397 -2
Lines 14508 14551 +43
==========================================
+ Hits 10358 10388 +30
- Misses 3382 3390 +8
- Partials 768 773 +5
Continue to review full report at Codecov.
|
…fold into add-v2-definitions
70a2145
to
2a43649
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Over all LGTM
- Remove deprecated fields
- How can we make enums not version specific.
Related: #5368 , #5422, #5423
Description
This PR adds the proto file containing the definitions for message types that will be used as part of the v2 API. Most of this is copy-paste from proto/v1/skaffold.proto. The main changes are to the Event API related messages, as well as the service definition.
Follow-up Work (remove if N/A)