Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v2 Proto definitions #5415

Merged
merged 5 commits into from
Mar 2, 2021

Conversation

MarlonGamez
Copy link
Contributor

@MarlonGamez MarlonGamez commented Feb 18, 2021

Related: #5368 , #5422, #5423

Description
This PR adds the proto file containing the definitions for message types that will be used as part of the v2 API. Most of this is copy-paste from proto/v1/skaffold.proto. The main changes are to the Event API related messages, as well as the service definition.

Follow-up Work (remove if N/A)

  • Add Dockerfile and update scripts to generate proto files
  • Metadata proto messages will be updates later based on design from VSC IDE team

@google-cla google-cla bot added the cla: yes label Feb 18, 2021
@MarlonGamez MarlonGamez changed the title Add v2 definitions Add v2 Proto definitions Feb 18, 2021
@MarlonGamez MarlonGamez added this to the v1.21.0-rc milestone Feb 18, 2021
@codecov
Copy link

codecov bot commented Feb 18, 2021

Codecov Report

Merging #5415 (4055e0c) into master (2c91d23) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5415      +/-   ##
==========================================
- Coverage   71.39%   71.39%   -0.01%     
==========================================
  Files         399      397       -2     
  Lines       14508    14551      +43     
==========================================
+ Hits        10358    10388      +30     
- Misses       3382     3390       +8     
- Partials      768      773       +5     
Impacted Files Coverage Δ
pkg/skaffold/test/structure/structure.go 87.50% <0.00%> (-12.50%) ⬇️
pkg/skaffold/util/tar.go 50.66% <0.00%> (-5.34%) ⬇️
pkg/skaffold/runner/new.go 67.58% <0.00%> (-1.70%) ⬇️
pkg/skaffold/docker/image.go 78.13% <0.00%> (-1.40%) ⬇️
pkg/skaffold/test/structure/error.go 100.00% <0.00%> (ø)
pkg/skaffold/instrumentation/types.go 0.00% <0.00%> (ø)
pkg/skaffold/test/error.go
pkg/skaffold/test/test.go
pkg/skaffold/test/structure/types.go
pkg/skaffold/test/test_factory.go 78.94% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c91d23...4055e0c. Read the comment docs.

@MarlonGamez MarlonGamez marked this pull request as ready for review February 19, 2021 19:07
@MarlonGamez MarlonGamez requested a review from a team as a code owner February 19, 2021 19:07
Copy link
Contributor

@tejal29 tejal29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Over all LGTM

  1. Remove deprecated fields
  2. How can we make enums not version specific.

proto/v2/skaffold.proto Outdated Show resolved Hide resolved
proto/v2/skaffold.proto Show resolved Hide resolved
proto/v2/skaffold.proto Outdated Show resolved Hide resolved
proto/v2/skaffold.proto Show resolved Hide resolved
proto/v2/skaffold.proto Outdated Show resolved Hide resolved
proto/v2/skaffold.proto Show resolved Hide resolved
@tejal29 tejal29 merged commit 5a33b24 into GoogleContainerTools:master Mar 2, 2021
@MarlonGamez MarlonGamez self-assigned this Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants