Add prompt for users to pick manifests to generate during skaffold init --generate-manifests
#5312
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5312 +/- ##
==========================================
+ Coverage 71.79% 71.84% +0.05%
==========================================
Files 390 390
Lines 14202 14213 +11
==========================================
+ Hits 10196 10212 +16
+ Misses 3255 3253 -2
+ Partials 751 748 -3
Continue to review full report at Codecov.
|
| @@ -76,11 +77,26 @@ func WriteSkaffoldConfig(out io.Writer, pipeline []byte, generatedManifests map[ | |||
| return !response, nil | |||
| } | |||
|
|
|||
| // chooseBuilders prompts the user to select which builders they'd like to create associated kubernetes manifests for | |||
| func chooseBuilders(builders []string) ([]string, error) { | |||
| chosen := []string{} | |||
There was a problem hiding this comment.
Is none-by-default the right default? Are you thinking that we will have many false positives to prompt from?
(The survey package does offer a <right> to select all so this isn't really that important.)
There was a problem hiding this comment.
Can't say I have a good answer for if it's the right default, but I agree having the ability to select all and select none mean it shouldn't matter too much
Fixes: #5310
Description
This adds a new prompt to let users select which kubernetes manifests they'd like to create when running
skaffold init --generate-manifestsUser facing changes (remove if N/A)
Users will see a new prompt when running
initwith--generate-manifeststhat looks like this