Render uses Helm templated values-file #5170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5170 +/- ##
==========================================
+ Coverage 71.85% 71.88% +0.02%
==========================================
Files 384 384
Lines 13729 13728 -1
==========================================
+ Hits 9865 9868 +3
+ Misses 3138 3136 -2
+ Partials 726 724 -2
Continue to review full report at Codecov.
|
IsaacPD
approved these changes
Dec 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5163
Description
Helm's
renderimplementation redundantly adds the values-files, even though it is already done inconstructOverrideArgs(), which further allows templating of the file name. This PR removes the redundant processing.