remove wsl detection logic #5124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5124 +/- ##
==========================================
+ Coverage 72.19% 72.25% +0.06%
==========================================
Files 380 379 -1
Lines 13303 13297 -6
==========================================
+ Hits 9604 9608 +4
+ Misses 3006 2999 -7
+ Partials 693 690 -3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5085
Related: #5054
Description
The previous WSL logic is antiquated as WSL is its own fully functional linux system. There does not need to be any extra hacks or logic when running within WSL so long as the necessary tools as normal are present. Thus using Docker with the WSL2 backend is a must for anyone using WSL as it allows seamless integration with the tools (e.g. skaffold) that use it.
User facing changes
None hopefully, potentially a change for the better in how users use skaffold in WSL if they are not already working with all linux binaries from within WSL.