-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default kaniko image to gcr.io/k8s-skaffold/skaffold-helpers/busybox
from busybox
#5080
Change default kaniko image to gcr.io/k8s-skaffold/skaffold-helpers/busybox
from busybox
#5080
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5080 +/- ##
==========================================
- Coverage 72.38% 72.38% -0.01%
==========================================
Files 368 372 +4
Lines 12934 13114 +180
==========================================
+ Hits 9362 9492 +130
- Misses 2884 2931 +47
- Partials 688 691 +3
Continue to review full report at Codecov.
|
bb8cbc0
to
e4ee2ec
Compare
…pers/busybox` from `busybox`
e4ee2ec
to
388f5a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Can you specify in the description the steps to generate the image
gcr.io/k8s-skaffold/skaffold-helpers/busybox
Thanks
Tejal
gcr.io/google-containers/busybox:latest
from busybox
gcr.io/k8s-skaffold/skaffold-helpers/busybox
from busybox
Please update the PR description with steps you used to create the Thanks |
Just took a look at the description. Looks like its not intended to merge.
apologies about the outdated description. Thanks for merging anyway.
done. |
Fixes: #5045
Update the default kaniko helper image from
busybox
togcr.io/k8s-skaffold/skaffold-helpers/busybox
. Image generated via: