Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default kaniko image to gcr.io/k8s-skaffold/skaffold-helpers/busybox from busybox #5080

Merged

Conversation

gsquared94
Copy link
Contributor

@gsquared94 gsquared94 commented Nov 30, 2020

Fixes: #5045

Update the default kaniko helper image from busybox to gcr.io/k8s-skaffold/skaffold-helpers/busybox. Image generated via:

docker pull busybox:latest
docker tag busybox gcr.io/k8s-skaffold/skaffold-helpers/busybox:latest
docker push gcr.io/k8s-skaffold/skaffold-helpers/busybox:latest

@google-cla google-cla bot added the cla: yes label Nov 30, 2020
@gsquared94 gsquared94 added the kokoro:force-run forces a kokoro re-run on a PR label Nov 30, 2020
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Nov 30, 2020
@codecov
Copy link

codecov bot commented Nov 30, 2020

Codecov Report

Merging #5080 (388f5a8) into master (908ba43) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5080      +/-   ##
==========================================
- Coverage   72.38%   72.38%   -0.01%     
==========================================
  Files         368      372       +4     
  Lines       12934    13114     +180     
==========================================
+ Hits         9362     9492     +130     
- Misses       2884     2931      +47     
- Partials      688      691       +3     
Impacted Files Coverage Δ
pkg/skaffold/errors/errors.go 93.18% <0.00%> (-4.19%) ⬇️
pkg/skaffold/debug/cnb.go 91.25% <0.00%> (-1.35%) ⬇️
pkg/skaffold/build/jib/jib.go 70.54% <0.00%> (ø)
pkg/skaffold/build/jib/build.go 71.42% <0.00%> (ø)
pkg/skaffold/build/cache/lookup.go 87.87% <0.00%> (ø)
pkg/skaffold/errors/err_def.go 72.72% <0.00%> (ø)
pkg/skaffold/build/docker/errors.go 56.00% <0.00%> (ø)
pkg/skaffold/build/jib/errors.go 48.83% <0.00%> (ø)
pkg/skaffold/docker/errors.go 54.54% <0.00%> (ø)
pkg/skaffold/debug/transform.go 90.00% <0.00%> (+0.10%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 908ba43...388f5a8. Read the comment docs.

@gsquared94 gsquared94 force-pushed the update-kaniko-default-image branch from bb8cbc0 to e4ee2ec Compare November 30, 2020 22:38
@gsquared94 gsquared94 marked this pull request as ready for review December 1, 2020 16:21
@gsquared94 gsquared94 requested a review from a team as a code owner December 1, 2020 16:21
@gsquared94 gsquared94 requested a review from IsaacPD December 1, 2020 16:21
@gsquared94 gsquared94 force-pushed the update-kaniko-default-image branch from e4ee2ec to 388f5a8 Compare December 1, 2020 16:21
@gsquared94 gsquared94 requested a review from tejal29 December 1, 2020 16:21
tejal29
tejal29 previously approved these changes Dec 1, 2020
Copy link
Contributor

@tejal29 tejal29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Can you specify in the description the steps to generate the image
gcr.io/k8s-skaffold/skaffold-helpers/busybox

Thanks
Tejal

@tejal29 tejal29 changed the title Change default kaniko image to gcr.io/google-containers/busybox:latest from busybox Change default kaniko image to gcr.io/k8s-skaffold/skaffold-helpers/busybox from busybox Dec 1, 2020
@tejal29
Copy link
Contributor

tejal29 commented Dec 1, 2020

Please update the PR description with steps you used to create the gcr.io/k8s-skaffold/skaffold-helpers/busybox image.

Thanks
Tejal

@tejal29 tejal29 dismissed their stale review December 1, 2020 23:22

Just took a look at the description. Looks like its not intended to merge.

@tejal29 tejal29 merged commit 54466ff into GoogleContainerTools:master Dec 1, 2020
@gsquared94
Copy link
Contributor Author

Just took a look at the description. Looks like its not intended to merge.

apologies about the outdated description. Thanks for merging anyway.

Please update the PR description with steps you used to create the gcr.io/k8s-skaffold/skaffold-helpers/busybox image.

done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Are DockerHub rate limits going to be a problem for the busybox container
3 participants