Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] move DoInit phases into functions #5037

Merged
merged 3 commits into from
Nov 25, 2020

Conversation

MarlonGamez
Copy link
Contributor

Related: #4915

Description
No funcional changes, just organizing some skaffold init related code into functions, which will be useful for later when implementing necessary changes for #4915

Follow-up Work (remove if N/A)
Implement flow for transparently running skaffold init when the user doesn't have a config

@codecov
Copy link

codecov bot commented Nov 18, 2020

Codecov Report

Merging #5037 (ae71180) into master (7991add) will increase coverage by 0.09%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5037      +/-   ##
==========================================
+ Coverage   72.18%   72.28%   +0.09%     
==========================================
  Files         365      368       +3     
  Lines       12861    12927      +66     
==========================================
+ Hits         9284     9344      +60     
- Misses       2886     2891       +5     
- Partials      691      692       +1     
Impacted Files Coverage Δ
pkg/skaffold/initializer/init.go 58.92% <75.00%> (+7.76%) ⬆️
pkg/skaffold/docker/reference.go 100.00% <0.00%> (ø)
pkg/skaffold/docker/default_repo.go 100.00% <0.00%> (ø)
pkg/skaffold/schema/v2beta9/upgrade.go 100.00% <0.00%> (ø)
pkg/skaffold/kubernetes/manifest/images.go 100.00% <0.00%> (ø)
...g/skaffold/kubernetes/portforward/pod_forwarder.go 82.00% <0.00%> (ø)
...ffold/kubernetes/portforward/resource_forwarder.go 86.00% <0.00%> (ø)
...kubernetes/portforward/port_forward_integration.go 0.00% <0.00%> (ø)
pkg/skaffold/deploy/helm/helm.go
pkg/skaffold/deploy/helm/util.go 80.39% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7991add...ae71180. Read the comment docs.

@MarlonGamez MarlonGamez marked this pull request as ready for review November 18, 2020 22:32
@MarlonGamez MarlonGamez requested a review from a team as a code owner November 18, 2020 22:32
Copy link
Member

@tejal29 tejal29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of nits

pkg/skaffold/initializer/init.go Show resolved Hide resolved
@tejal29 tejal29 merged commit bbcfdb0 into GoogleContainerTools:master Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants