Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitTagger generates an invalid tag if there are uncommitted changes #5034

Merged
merged 1 commit into from
Nov 17, 2020
Merged

GitTagger generates an invalid tag if there are uncommitted changes #5034

merged 1 commit into from
Nov 17, 2020

Conversation

anshlykov
Copy link
Contributor

Fixes: #5033

@anshlykov anshlykov requested a review from a team as a code owner November 17, 2020 17:05
@google-cla google-cla bot added the cla: yes label Nov 17, 2020
@codecov
Copy link

codecov bot commented Nov 17, 2020 •
edited
Loading

Codecov Report

Merging #5034 (b31eedb) into master (d54c930) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5034   +/-   ##
=======================================
  Coverage   72.18%   72.18%           
=======================================
  Files         365      365           
  Lines       12859    12861    +2     
=======================================
+ Hits         9282     9284    +2     
  Misses       2886     2886           
  Partials      691      691
Impacted Files Coverage Δ
pkg/skaffold/build/tag/git_commit.go 88.46% <100.00%> (+0.22%) ⬆️
pkg/skaffold/deploy/kpt/kpt.go 75.26% <0.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d54c930...b31eedb. Read the comment docs.

@IsaacPD IsaacPD added the kokoro:run runs the kokoro jobs on a PR label Nov 17, 2020
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Nov 17, 2020
@IsaacPD IsaacPD merged commit abbe24e into GoogleContainerTools:master Nov 17, 2020
@anshlykov anshlykov deleted the gh-5033 branch November 18, 2020 09:26
@fmotrifork fmotrifork mentioned this pull request Nov 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IsaacPD IsaacPD IsaacPD approved these changes

@briandealwis briandealwis Awaiting requested review from briandealwis

Assignees
No one assigned
Labels
cla: yes size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GitTagger generates an invalid tag if there are uncommitted changes
3 participants
@anshlykov @IsaacPD @kokoro-team