Fix Bug that prevents showing survey prompt #5027
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug I introduced where the survey prompt will only show if os.Stdout does not support colors i.e. when
color.SetupColors(out, forceColors)
does not wrapout
.Description
Fixed by actually checking if the passed io.Writer is a wrapped colorableWriter. Added a test case to ensure that
color.IsStdout(color.NewWriter(os.Stdout))
returns trueBefore (master):
With an empty global config and running
skaffold build
in examples/getting-started, the survey prompt does not show up. This is becausesurvey.isStdout(out)
returns false when out = colorableWriter{os.Stdout}.After:
Survey prompt shows up given the same conditions above.