[KPT CODELAB] (1/3) New codelab dir + the sample application resources #5023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5023 +/- ##
==========================================
- Coverage 72.20% 72.18% -0.03%
==========================================
Files 365 365
Lines 12842 12842
==========================================
- Hits 9273 9270 -3
- Misses 2880 2881 +1
- Partials 689 691 +2
Continue to review full report at Codecov.
|
yuwenma
changed the title
yuwenma
changed the title
|
I think this should be fine to go in, since it's just the sample app files for the codelab. Took a look over everything and it seems good :) I'll run kokoro and merge assuming that goes well 👍🏼 |
Thank you! |
MarlonGamez
approved these changes
Nov 13, 2020
yuwenma
added a commit
to yuwenma/skaffold
that referenced
this pull request
Nov 16, 2020
MarlonGamez
pushed a commit
that referenced
this pull request
Dec 11, 2020
* [kpt codelab] Add codelab for kpt validations * update URL since 1/3 #5023 is merged * fix nits and issues * Change codelab content due to kpt v1 changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the sample application for the kpt codelab.
Fixes: #4881 #3904