Remove support for Helm 2 #5019
Conversation
|
I just saw this on the helm EOL announcement blog, To Be Removed
Until next release, we will be in spot where
Can we add a FAQ, or something on how to pass |
| @@ -469,7 +477,7 @@ func (h *Deployer) deployRelease(ctx context.Context, out io.Writer, r latest.He | |||
|
|
|||
| // getRelease confirms that a release is visible to helm | |||
| func (h *Deployer) getRelease(ctx context.Context, helmVersion semver.Version, releaseName string, namespace string) (bytes.Buffer, error) { | |||
| // Retry, because under Helm 2, at least, a release may not be immediately visible | |||
| // Retry, because sometimes a release may not be immediately visible | |||
There was a problem hiding this comment.
from the comments, looks like the retry logic was explicitly added maybe for helm2. Is there a way to verify if this is needed for helm3?
There was a problem hiding this comment.
thought about it, but it can't hurt to leave i think. if it's not needed then it will just get bypassed, and it serves as a safeguard in case we do actually end up needing it.
| args = append(args, "--namespace", namespace) | ||
| } | ||
| args := []string{"get", "all"} | ||
| if namespace != "" { |
There was a problem hiding this comment.
ah! looks like we passed the namespace arg only for helm2. :)
Wonder how helm3 users didn't hit this.
nkubala
force-pushed
the
helm-2-remove
branch
from
25f271d to
5def30b
Compare
i'm planning on making an announcement on slack about the deprecation, and what to do in a few scenarios - i could add this in there. i think that's probably enough? our docs won't get updated on the website until the release anyway (unless we did it manually), so not sure how many people would see it. |
Codecov Report
@@ Coverage Diff @@
## master #5019 +/- ##
==========================================
+ Coverage 72.17% 72.19% +0.01%
==========================================
Files 365 365
Lines 12807 12822 +15
==========================================
+ Hits 9244 9257 +13
Misses 2878 2878
- Partials 685 687 +2
Continue to review full report at Codecov.
|
I have ran the trigger for docs manually a couple of times when Skaffold Reference Yaml was broken. |
nkubala
force-pushed
the
helm-2-remove
branch
from
5def30b to
6a3f3a0
Compare
remove const var kustomizeFurtherGuidance
Fixes #4607
Helm 2 is reaching its end of life on November 13, 2020, after which date old chart repositories may no longer be available. To continue to align with the Helm project, this change removes support for Helm client versions older than 3.0.0-beta.0.
To get the most feature-rich and stable Skaffold experience, we recommend using Helm version 3.1 or greater.