Fix: Skaffold reloads unchanged, existing image again into the cluster

[anshlykov]

Related: #4955

Description
the command kubectl get nodes -ojsonpath = '{@.items[*].status.images[*].names[*]}' returns a list with normalized image refs. The returned image may differ from artifact.Tag. This PR adds image normalization before checking already loaded images.

[codecov]

Codecov Report

Merging #4983 into master will increase coverage by 0.01%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master    #4983      +/-   ##
==========================================
+ Coverage   72.27%   72.28%   +0.01%     
==========================================
  Files         361      361              
  Lines       12640    12670      +30     
==========================================
+ Hits         9135     9159      +24     
- Misses       2827     2830       +3     
- Partials      678      681       +3     

Impacted Files	Coverage Δ
pkg/skaffold/runner/load_images.go	94.73% <50.00%> (-5.27%)	⬇️
pkg/skaffold/build/buildpacks/types.go	100.00% <0.00%> (ø)
pkg/skaffold/docker/parse.go	85.47% <0.00%> (+0.16%)	⬆️
pkg/skaffold/build/buildpacks/lifecycle.go	81.72% <0.00%> (+0.56%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd2a38f...18496ce. Read the comment docs.

[tejal29]

This change looks good to me and makes sense. We shd ship this change

However, i am not sure how it fixes #4955.

From the issue logs looks like we were checking a tag "eu.gcr.io/tools-org-veroo/party-service:d46578239dd325395e15e8ab16a2c499616a15e662ed196c18549e8d2bea38b6" which exist in the kubectl get nodes -o jsonpath='{@.items[*].status.images[*].names[*]}

am i missing something obvious?

[anshlykov]

From the issue logs looks like we were checking a tag "eu.gcr.io/tools-org-veroo/party-service:d46578239dd325395e15e8ab16a2c499616a15e662ed196c18549e8d2bea38b6" which exist in the kubectl get nodes -o jsonpath='{@.items[].status.images[].names[*]}

@tejal29 You're right. My bad I missed it in the description. It looks like I faced with another issue.

[anshlykov]

But also I was unable to fully reproduce the bug described here, perhaps due to a lack of information.