Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validate tag policy constrain #4890

Merged
merged 3 commits into from
Oct 15, 2020
Merged

validate tag policy constrain #4890

merged 3 commits into from
Oct 15, 2020

Conversation

StarpTech
Copy link
Contributor

Fixes: #4889

@google-cla google-cla bot added the cla: yes label Oct 9, 2020
@codecov
Copy link

codecov bot commented Oct 9, 2020 •
edited
Loading

Codecov Report

Merging #4890 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4890      +/-   ##
==========================================
+ Coverage   72.07%   72.08%   +0.01%     
==========================================
  Files         358      358              
  Lines       12364    12369       +5     
==========================================
+ Hits         8911     8916       +5     
  Misses       2797     2797              
  Partials      656      656
Impacted Files Coverage Δ
pkg/skaffold/schema/validation/validation.go 96.05% <100.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e5ae4c...e6b8851. Read the comment docs.

@briandealwis briandealwis added triage/discuss Items for discussion kokoro:run runs the kokoro jobs on a PR labels Oct 13, 2020
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Oct 13, 2020
briandealwis
briandealwis reviewed Oct 14, 2020
View reviewed changes
Copy link
Member

@briandealwis briandealwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Could you please merge with HEAD and address these two issues, and we can get this in?

@StarpTech
Merge branch 'master' into 4889_validate_image_tag_policy
e6b8851 
# Conflicts:
#	pkg/skaffold/schema/validation/validation_test.go
@StarpTech
Copy link
Contributor Author

23min for CI is a lot 😄

@StarpTech StarpTech marked this pull request as ready for review October 15, 2020 09:53
@StarpTech StarpTech requested a review from a team as a code owner October 15, 2020 09:53
@StarpTech StarpTech requested a review from nkubala October 15, 2020 09:53
@briandealwis briandealwis added kokoro:run runs the kokoro jobs on a PR and removed triage/discuss Items for discussion labels Oct 15, 2020
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Oct 15, 2020
@briandealwis briandealwis merged commit 7eac10c into GoogleContainerTools:master Oct 15, 2020
@fmotrifork fmotrifork mentioned this pull request Nov 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandealwis briandealwis briandealwis approved these changes

@nkubala nkubala Awaiting requested review from nkubala

Assignees
No one assigned
Labels
cla: yes size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update docs on behaviour of tryImportMissing
3 participants
@StarpTech @briandealwis @kokoro-team