Fix debug for Helm on Windows

[briandealwis]

Fixes: #4862
Related to: #4732

Description
To support debug in our Helm deployer, we create a Skaffold command-line that we encode in the SKAFFOLD_CMDLINE environment variable, something like:

[]string{"filter", "--debugging", "--kube-context", "kubecontext", "--build-artifacts", "buildfile", "--kubeconfig", "kubeconfig"}

We're just using strings.Join() to build up this command-line:

skaffold/pkg/skaffold/deploy/helm/helm.go

Line 399 in da65fa5

env["SKAFFOLD_CMDLINE"] = strings.Join(cmdLine, " ")

But in Windows, the buildfile has backslashes in the name. And we parse our this command-line using shell.Split() which interprets backslashes:

skaffold/cmd/skaffold/app/skaffold.go

Line 39 in da65fa5

parsed, err := shell.Split(cmdLine)

And so the directory separators are being stripped out and the path name is not found.

[codecov]

Codecov Report

Merging #4872 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4872      +/-   ##
==========================================
+ Coverage   71.86%   71.88%   +0.02%     
==========================================
  Files         356      356              
  Lines       12218    12218              
==========================================
+ Hits         8780     8783       +3     
+ Misses       2786     2785       -1     
+ Partials      652      650       -2     

Impacted Files	Coverage Δ
pkg/skaffold/deploy/helm/helm.go	74.61% <100.00%> (ø)
pkg/skaffold/docker/image.go	80.75% <0.00%> (+1.40%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da65fa5...fd5c78a. Read the comment docs.

[aurelien-baumann-lacapitale]

If it helps, I can build it locally and test it on Windows.

[briandealwis]

Please do @aurelien-baumann-lacapitale!

[aurelien-baumann-lacapitale]

@briandealwis it works! Thank you 🎉👌

[MarlonGamez]

Looks good 👍🏼

[alisters]

@aurelien-baumann-lacapitale - this is a long shot, but how did you build on windows ? I'd like to also test this fix (to see if this fix's cloud code in intellij not attaching), but hopefully to be able to provide some future fixes too. I'm a Go newbie, and it's been 20 years since i wrote Makefiles so my attempts to build skaffold in powershell and cmd.exe are failing miserably....

What target did you execute ?
What shell/platform did you build in/on ? WSL ? (I see there is cross compile make target rules)
Can skaffold even be built on cmd or powershell ? I see it runs some shell scripts to generate some code so i'm guessing not ?

One word answers are fine ! :-)

For anyone else that finds this i managed to cross compile in WSL, producing a binary for windows by following this guide - https://www.digitalocean.com/community/tutorials/how-to-build-go-executables-for-multiple-platforms-on-ubuntu-16-04.

env GOOS=windows GOARCH=amd64 make

Then renamed the binary skaffold.exe and copied into an appropriate location.

Tested that the fix worked, cloud code attached successfully, and now see this has been merged and released in 1.16.

[aurelien-baumann-lacapitale]

Hey @alisters you seem to have cracked it alright. Sorry for my non-reactivity on that one 🤭