Move deployers into separate packages #4812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkubala
requested review from
loosebazooka,
yuwenma and
a team
as code owners
nkubala
force-pushed
the
deploy-packages
branch
from
f3a7d85 to
fdc46d9
Compare
Codecov Report
@@ Coverage Diff @@
## master #4812 +/- ##
==========================================
- Coverage 71.77% 71.75% -0.03%
==========================================
Files 348 353 +5
Lines 12082 12087 +5
==========================================
+ Hits 8672 8673 +1
+ Misses 2771 2770 -1
- Partials 639 644 +5
Continue to review full report at Codecov.
|
yuwenma
reviewed
Sep 21, 2020
yuwenma
reviewed
Sep 21, 2020
yuwenma
reviewed
Sep 21, 2020
yuwenma
reviewed
Sep 21, 2020
yuwenma
reviewed
Sep 21, 2020
yuwenma
reviewed
Sep 21, 2020
yuwenma
reviewed
Sep 21, 2020
yuwenma
reviewed
Sep 21, 2020
yuwenma
reviewed
Sep 21, 2020
yuwenma
reviewed
Sep 21, 2020
yuwenma
reviewed
Sep 21, 2020
yuwenma
previously requested changes
Sep 21, 2020
nkubala
force-pushed
the
deploy-packages
branch
from
30f8709 to
7ca5b06
Compare
gsquared94
reviewed
Sep 22, 2020
gsquared94
reviewed
Sep 22, 2020
pkg/skaffold/deploy/deploy_mux.go
Outdated
| @@ -103,5 +78,5 @@ func (m DeployerMux) Render(ctx context.Context, w io.Writer, as []build.Artifac | |||
| } | |||
|
|
|||
| allResources := strings.Join(resources, "\n---\n") | |||
| return outputRenderedManifests(allResources, filepath, w) | |||
| return manifest.OutputRenderedManifests(allResources, filepath, w) | |||
There was a problem hiding this comment.
OutputRenderedManifests to probably OutputRender
There was a problem hiding this comment.
WDYT about manifest.Write()? the fact that the manifests are rendered seems like an implementation detail to me
gsquared94
reviewed
Sep 22, 2020
gsquared94
reviewed
Sep 22, 2020
gsquared94
reviewed
Sep 22, 2020
gsquared94
suggested changes
Sep 22, 2020
gsquared94
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a non-functional refactor to move each deployer into its own package, to improve readability of the code and clarity around what methods apply where. this will also make it easier to further consolidate and/or make changes to shared deploy code in the future.
review guide:
pkg/skaffold/deploy:kubectl,kustomize,helm,kpt,label,status,utilpkg/skaffold/deploy/utilcontains shared util code related toLogFileandStringSetpkg/skaffold/deploy/types, which contains shared types across other deploy packagespkg/skaffold/deploy/kubectland intopkg/skaffold/kubernetes/manifest, since it is sharedkustomize.BuildCommandArgsbeing used inpkg/skaffold/deploy/kpt)follow-up work: move
kubectl.Configout ofpkg/skaffold/deploy/kubectl, since it is shared outside of this package.