[kpt deployer] Add "local-config" annotation to kpt fn configs. #4803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `config.kubernetes.io/local-config:true` annotation will skip the kpt fn resource from deploying to the cluster in `kpt live apply`.
yuwenma
force-pushed
the
exclude-kpt-fn
branch
from
0fa7e0a
to
6ebae64
Compare
|
/assign @MarlonGamez |
Codecov Report
@@ Coverage Diff @@
## master #4803 +/- ##
==========================================
- Coverage 71.82% 71.62% -0.21%
==========================================
Files 347 348 +1
Lines 11869 12051 +182
==========================================
+ Hits 8525 8631 +106
- Misses 2725 2781 +56
- Partials 619 639 +20
Continue to review full report at Codecov.
|
MarlonGamez
reviewed
Sep 18, 2020
yuwenma
force-pushed
the
exclude-kpt-fn
branch
from
15e1a78
to
ade595c
Compare
yuwenma
force-pushed
the
exclude-kpt-fn
branch
from
ade595c
to
4e60daf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #3904
Description
Add a
config.kubernetes.io/local-config:trueannotation to each kpt fn config from the rendered resources. This allows kpt deployer to skip deploying the kpt fn config to the cluster inskaffold devandskaffold deploy.more context: The declarative kpt fn is not config resource but an operation working on the resource. It should not be applied to the cluster. Applying the kpt fn to cluster could fail due to the different config requirements (e.g. kpt fn ConfigMap doesn't require the
.metadata.namefield to exist while normal ConfigMap does).