Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return error for invalid dockerfile instruction "COPY" with no arguments #4795

Merged
merged 1 commit into from
Sep 17, 2020
Merged

Return error for invalid dockerfile instruction "COPY" with no arguments #4795

merged 1 commit into from
Sep 17, 2020

Conversation

gsquared94
Copy link
Contributor

Fixes #4791

@gsquared94 gsquared94 requested a review from a team as a code owner September 16, 2020 18:22
@codecov
Copy link

codecov bot commented Sep 16, 2020 •
edited
Loading

Codecov Report

Merging #4795 into master will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4795      +/-   ##
==========================================
- Coverage   73.85%   73.84%   -0.02%     
==========================================
  Files         347      347              
  Lines       13796    13798       +2     
==========================================
  Hits        10189    10189              
- Misses       2972     2973       +1     
- Partials      635      636       +1
Impacted Files Coverage Δ
pkg/skaffold/docker/parse.go 89.05% <0.00%> (-0.90%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10275c6...a0bb8f1. Read the comment docs.

ilya-zuyev
ilya-zuyev reviewed Sep 16, 2020
View reviewed changes
Copy link
Contributor

@ilya-zuyev ilya-zuyev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gsquared94 gsquared94 merged commit 0917dba into GoogleContainerTools:master Sep 17, 2020
@gsquared94 gsquared94 deleted the fix-4791 branch September 17, 2020 12:02
@fmotrifork fmotrifork mentioned this pull request Oct 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilya-zuyev ilya-zuyev ilya-zuyev left review comments

@nkubala nkubala nkubala approved these changes

@briandealwis briandealwis Awaiting requested review from briandealwis

Assignees
No one assigned
Labels
cla: yes size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Skaffold panics if Dockerfile contains 'COPY' line
4 participants
@gsquared94 @nkubala @ilya-zuyev @googlebot