Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename NewFromRunContext() to NewCLI() #4743

Merged
merged 1 commit into from
Aug 31, 2020

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Aug 31, 2020

We don't pass a RunContext anymore.

Signed-off-by: David Gageot [email protected]

@dgageot dgageot requested a review from a team as a code owner August 31, 2020 16:45
@dgageot dgageot requested a review from gsquared94 August 31, 2020 16:45
@codecov
Copy link

codecov bot commented Aug 31, 2020

Codecov Report

Merging #4743 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4743   +/-   ##
=======================================
  Coverage   73.41%   73.41%           
=======================================
  Files         345      345           
  Lines       13739    13739           
=======================================
  Hits        10086    10086           
  Misses       3020     3020           
  Partials      633      633           
Impacted Files Coverage Δ
pkg/skaffold/build/cluster/types.go 100.00% <100.00%> (ø)
pkg/skaffold/deploy/kubectl/cli.go 88.63% <100.00%> (ø)
pkg/skaffold/deploy/resource/deployment.go 91.54% <100.00%> (ø)
pkg/skaffold/kubectl/cli.go 100.00% <100.00%> (ø)
pkg/skaffold/runner/new.go 67.54% <100.00%> (ø)
pkg/skaffold/sync/types.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d64b7df...e171153. Read the comment docs.

@dgageot dgageot merged commit b642a69 into GoogleContainerTools:master Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants