-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extending Workflow for Kpt Deployer (accepting additional arguments) #4736
Extending Workflow for Kpt Deployer (accepting additional arguments) #4736
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4736 +/- ##
==========================================
- Coverage 73.45% 73.38% -0.08%
==========================================
Files 343 345 +2
Lines 13585 13739 +154
==========================================
+ Hits 9979 10082 +103
- Misses 2982 3023 +41
- Partials 624 634 +10
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet! Great job on the last PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Related: #3904
Description
This contains the implementation and additional test cases allowing users to specify additional arguments when running
kpt fn
orkpt live
commands with Skaffold.User facing changes
Users will have the option to specify additional arguments in their skaffold.yaml.
Follow-up Work
It may be a good idea to add more validation to the config in the future such as validating the values of these arguments to fit certain patterns and catch the error before the command is called.
Before:
After: