Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move DetectWSL function into util package #4721

Merged
merged 2 commits into from
Aug 27, 2020

Conversation

gsquared94
Copy link
Contributor

Moved DetectWSL function into util package. This is a prereq for #4701

@codecov
Copy link

codecov bot commented Aug 26, 2020

Codecov Report

Merging #4721 into master will increase coverage by 0.00%.
The diff coverage is 45.45%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4721   +/-   ##
=======================================
  Coverage   73.42%   73.42%           
=======================================
  Files         342      343    +1     
  Lines       13529    13560   +31     
=======================================
+ Hits         9934     9957   +23     
- Misses       2976     2980    +4     
- Partials      619      623    +4     
Impacted Files Coverage Δ
pkg/skaffold/docker/client.go 79.38% <0.00%> (+2.02%) ⬆️
pkg/skaffold/util/wsl.go 55.55% <55.55%> (ø)
pkg/skaffold/deploy/kpt.go 82.85% <0.00%> (-2.47%) ⬇️
pkg/skaffold/kubernetes/owner.go 87.50% <0.00%> (ø)
pkg/skaffold/kubernetes/watcher.go 87.50% <0.00%> (ø)
pkg/skaffold/build/cluster/kaniko.go 0.00% <0.00%> (ø)
pkg/webhook/kubernetes/deployment.go 0.00% <0.00%> (ø)
pkg/skaffold/kubernetes/client.go
pkg/skaffold/kubernetes/client/client.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 241e202...d81a762. Read the comment docs.

pkg/skaffold/docker/client.go Show resolved Hide resolved
pkg/skaffold/util/wsl.go Show resolved Hide resolved
@gsquared94 gsquared94 merged commit f54a62b into GoogleContainerTools:master Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants