Log when values are taken from global config file #4566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4566 +/- ##
==========================================
- Coverage 72.61% 72.59% -0.03%
==========================================
Files 335 335
Lines 12964 12971 +7
==========================================
+ Hits 9414 9416 +2
- Misses 2957 2960 +3
- Partials 593 595 +2
Continue to review full report at Codecov.
|
tejal29
reviewed
Jul 24, 2020
| @@ -73,6 +73,9 @@ func readConfigFileCached(filename string) (*GlobalConfig, error) { | |||
| return | |||
| } | |||
| configFile, configFileErr = ReadConfigFileNoCache(filenameOrDefault) | |||
| if configFileErr == nil { | |||
| logrus.Infof("Loaded Skaffold defaults from %q", filenameOrDefault) | |||
There was a problem hiding this comment.
shd we move this to debug? I usually set my default-repo etc in global config when demoing so that the command line is as simple as skaffold dev on examples.
This will add more logs statements.
There was a problem hiding this comment.
Skaffold's default log-level is warning, so this will only appear if run with -v info.
nkubala
approved these changes
Jul 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log when values are resolved from the Skaffold global config file (typically ~/.skaffold/config). At least simplifies diagnosing situations like the motivation for #4554.