-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify usage of ArtifactOverrides, ImageStrategy #4487
Clarify usage of ArtifactOverrides, ImageStrategy #4487
Conversation
ArtifactOverrides was incorrectly claiming it needed "values file" syntax, i.e. structured YAML, but it actually takes `--set-string` syntax, i.e. dotted path. Also tied ArtifactOverrides directly to `ImageStrategy`, since the two work together. Signed-off-by: Paul "Hampy" Hampson <[email protected]>
Signed-off-by: Paul "Hampy" Hampson <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #4487 +/- ##
==========================================
+ Coverage 72.39% 74.24% +1.84%
==========================================
Files 334 338 +4
Lines 12992 14682 +1690
==========================================
+ Hits 9406 10901 +1495
- Misses 2987 3136 +149
- Partials 599 645 +46
Continue to review full report at Codecov.
|
Thanks for your contribution @TBBle. However this same change has already been checked in via a different PR so I'll close this one. |
@gsquared94 Can you tell which PR these changes are now in? I don't see them in the master branch, i.e. the |
My bad, #4503 fixed the mistake in documentation for |
Ah yes. I'd already rebased on #4503. |
Oops, and in the meantime, v2beta6 was released, so to pass CI I need to create a v2beta7. It seems a shame that I need to do that just for documentation updates. So I'll sit on this for now, and once there's an actual v2beta7 config schema, rebase onto that. |
hey! Just wanted to follow up and let you know that there's a v2beta7 now :) |
This change is a doc only change for the schema. |
Related: #500, specifically addressing this comment
Description
ArtifactOverrides was incorrectly claiming it needed "values file" syntax, i.e. structured YAML, but it actually takes
--set-string
syntax, i.e. dotted path.Also tied
ArtifactOverrides
directly toImageStrategy
, since the two work together.Follow-up Work
I didn't check that
ImageStrategy
is meaningfully documented, so it might need a closer look too.