Improve the error message when a released schema is changed

[dgageot]

Fixes #4168

Old message:

$ ./hack/check-schema-changes.sh
INFO[0000] structural changes in latest config, checking on Github if latest is released...
INFO[0000] Current Skaffold version: v2beta5
v2beta5 is released, it should NOT be changed!
ERRO[0000] --------
Structural change detected in a released config: pkg/skaffold/schema/latest/config.go
Please create a new PR first with a new version.
You can use 'hack/new_version.sh' to generate the new config version.
If you are running this locally, make sure you have the origin/master branch up to date!
Admin rights are required to merge this PR!
--------
diff --git a/pkg/skaffold/schema/latest/config.go b/pkg/skaffold/schema/latest/config.go
index 98f7921b4..e837615b6 100644
--- a/pkg/skaffold/schema/latest/config.go
+++ b/pkg/skaffold/schema/latest/config.go
@@ -403,6 +403,8 @@ type TestCase struct {
 type DeployConfig struct {
 	DeployType `yaml:",inline"`

+	Change bool
+
 	// StatusCheckDeadlineSeconds *beta* is the deadline for deployments to stabilize in seconds.
 	StatusCheckDeadlineSeconds int `yaml:"statusCheckDeadlineSeconds,omitempty"`

FATA[0000] structural changes detected
exit status 1

New message:

$ ./hack/check-schema-changes.sh
WARN[0000] Detected changes to the latest config. Checking on Github if it's released...
ERRO[0000] Schema "v2beta5" is already released. Changing it is not allowed.

What should I do?
-----------------
 + Please first create a new PR, with a new version, using 'hack/new_version.sh' script.
 + If you see this error and it seems incorrect, maybe you have an out-of-date "origin/master" local branch.
 + If this retroactive change is required and harmless to the users, you'll need Admin rights to merge this PR.

Invalid changes:
----------------
diff --git a/pkg/skaffold/schema/latest/config.go b/pkg/skaffold/schema/latest/config.go
index 98f7921b4..e837615b6 100644
--- a/pkg/skaffold/schema/latest/config.go
+++ b/pkg/skaffold/schema/latest/config.go
@@ -403,6 +403,8 @@ type TestCase struct {
 type DeployConfig struct {
 	DeployType `yaml:",inline"`

+	Change bool
+
 	// StatusCheckDeadlineSeconds *beta* is the deadline for deployments to stabilize in seconds.
 	StatusCheckDeadlineSeconds int `yaml:"statusCheckDeadlineSeconds,omitempty"`

exit status 1

Signed-off-by: David Gageot [email protected]

[codecov]

Codecov Report

Merging #4355 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4355   +/-   ##
=======================================
  Coverage   71.74%   71.74%           
=======================================
  Files         324      324           
  Lines       12506    12506           
=======================================
  Hits         8973     8973           
  Misses       2965     2965           
  Partials      568      568           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e5d7c3...bc67ba0. Read the comment docs.

[briandealwis]

This doesn't seem right since errors reading config files (lines 50-80) will be silently dropped.

[dgageot]

@briandealwis Can you TAL again? Thanks!