-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hook up showing survey prompt if not taken or recently prompted #4306
hook up showing survey prompt if not taken or recently prompted #4306
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4306 +/- ##
==========================================
- Coverage 71.93% 71.91% -0.02%
==========================================
Files 322 322
Lines 12313 12341 +28
==========================================
+ Hits 8857 8875 +18
- Misses 2896 2902 +6
- Partials 560 564 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few wording suggestions and one comment but in general LGTM
// Today's date | ||
today := current().Format(time.RFC3339) | ||
ai := fmt.Sprintf(updateLastPrompted, today) | ||
aiErr := fmt.Errorf("could not automatically update the survey prompted timestamp - please run `%s`", ai) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this something we actually want the user to do? feels a little weird that we'd tell them to run a command to set a prompt timestamp - maybe we should tell them if this keeps happening to disable instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we ask users to disable the prompt, they would never see the prompt.
This command would silence it for 2 weeks.
How about we add the command to disable permanently here -> https://skaffold.dev/docs/resources/feedback/ or as part of FAQ.
And change the message to
could not automatically update the survey prompted timestamp -
please run skaffold config set --survey --global last-prompted 2019-10-20XXX
or see <> to permanently disable the prompt.
Or
could not automatically update the survey prompted timestamp
- please run
skaffold config set --survey --global last-prompted 2019-10-20XXX
or
run `skaffold config set --survey --global disable-prompt true` to permanently disable the prompt.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in any case we're still asking the user to run a command...but after thinking about it a little more I think it's probably fine. we can always change it later if it seems too annoying
Fixes: #4046
In this PR, skaffold will show the survey prompt to users if
** UI Changes **
** Testing**
** Manual tests **
1. Survey not taken in last 3 months or not prompted recently
a.
~/.skaffold/config
:b. Run any skaffold command
2. Survey not taken in last 3 months but prompted recently
a. Skaffold config
b. Run skaffold command and verify prompt is not shown.
3. Survey not taken in last 3 months but prompted but 2 weeks ago
a. set survey prompted taken to last month
b. Run any skaffold command and verify the prompt is shown.
4. Survey taken in last 3 months.
a. Set survey taken in last 3 months and not recently prompted
b. Run skaffold command and verify the prompt is not displayed