Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[buildpacks] Support trusted builders #4273

Merged
merged 1 commit into from
May 29, 2020

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented May 28, 2020

Signed-off-by: David Gageot [email protected]

@codecov
Copy link

codecov bot commented May 28, 2020

Codecov Report

Merging #4273 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
pkg/skaffold/schema/latest/config.go 100.00% <ø> (ø)
pkg/skaffold/build/buildpacks/lifecycle.go 82.89% <100.00%> (+0.22%) ⬆️
pkg/skaffold/build/gcb/buildpacks.go 100.00% <100.00%> (ø)
...affold/kubernetes/portforward/kubectl_forwarder.go 60.97% <0.00%> (-2.44%) ⬇️

Copy link
Member

@briandealwis briandealwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also change the examples to mark gcr.io/buildpacks/builder as trusted?

@dgageot
Copy link
Contributor Author

dgageot commented May 28, 2020 via email

@dgageot dgageot merged commit 3f39122 into GoogleContainerTools:master May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants