Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tolerations option for building image with kaniko #4256

Merged
merged 2 commits into from
May 29, 2020
Merged

add tolerations option for building image with kaniko #4256

merged 2 commits into from
May 29, 2020

Conversation

GwonsooLee
Copy link
Contributor

Fixes: #nnn

Description
When building image with kaniko, kaniko pod cannot be scheduled if all nodes are tainted for management issue. Tolerations is common kubernetes pod option so that, even though there is no issue published related to this, it would be helpful if this feature in on.

User facing changes (remove if N/A)
Yes, when to use kaniko with tainted node
image

image

Follow-up Work (remove if N/A)

  • Add Tolerations feature in cluster_detail

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@GwonsooLee
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@codecov
Copy link

codecov bot commented May 26, 2020

Codecov Report

Merging #4256 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
pkg/skaffold/schema/latest/config.go 100.00% <ø> (ø)
pkg/skaffold/build/cluster/pod.go 87.50% <100.00%> (+0.14%) ⬆️
...affold/kubernetes/portforward/kubectl_forwarder.go 60.97% <0.00%> (-2.44%) ⬇️

@briandealwis briandealwis added the kokoro:run runs the kokoro jobs on a PR label May 28, 2020
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label May 28, 2020
Copy link
Member

@briandealwis briandealwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nit

@@ -8,6 +8,12 @@ build:
cluster:
pullSecretName: e2esecret
namespace: default
# If kaniko pod should be run on the tainted node, You can setup tolerations here.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# If kaniko pod should be run on the tainted node, You can setup tolerations here.
# If kaniko pod should be run on a tainted node, you can setup tolerations here.

Copy link
Contributor

@tejal29 tejal29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except minor nit.

@GwonsooLee
Copy link
Contributor Author

GwonsooLee commented May 28, 2020

@briandealwis @tejal29 Thanks for review. I fix the minor nit :)

Copy link
Member

@briandealwis briandealwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@briandealwis briandealwis added the kokoro:run runs the kokoro jobs on a PR label May 29, 2020
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label May 29, 2020
@briandealwis briandealwis merged commit 78d2d2f into GoogleContainerTools:master May 29, 2020
@GwonsooLee GwonsooLee deleted the add_toleration_in_kaniko branch May 29, 2020 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants