-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tolerations option for building image with kaniko #4256
add tolerations option for building image with kaniko #4256
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Codecov Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor nit
examples/kaniko/skaffold.yaml
Outdated
@@ -8,6 +8,12 @@ build: | |||
cluster: | |||
pullSecretName: e2esecret | |||
namespace: default | |||
# If kaniko pod should be run on the tainted node, You can setup tolerations here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# If kaniko pod should be run on the tainted node, You can setup tolerations here. | |
# If kaniko pod should be run on a tainted node, you can setup tolerations here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except minor nit.
@briandealwis @tejal29 Thanks for review. I fix the minor nit :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Fixes: #nnn
Description
When building image with kaniko, kaniko pod cannot be scheduled if all nodes are tainted for management issue.
Tolerations
is common kubernetes pod option so that, even though there is no issue published related to this, it would be helpful if this feature in on.User facing changes (remove if N/A)
Yes, when to use kaniko with tainted node
Follow-up Work (remove if N/A)