Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default buildpacks #4070

Merged
merged 1 commit into from
Apr 30, 2020
Merged

Change default buildpacks #4070

merged 1 commit into from
Apr 30, 2020

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Apr 30, 2020

Signed-off-by: David Gageot [email protected]

@codecov
Copy link

codecov bot commented Apr 30, 2020 •
edited
Loading

Codecov Report

Merging #4070 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
pkg/skaffold/runner/runcontext/context.go 74.35% <ø> (-2.39%) ⬇️
cmd/skaffold/app/cmd/init.go 100.00% <100.00%> (ø)
pkg/skaffold/build/cache/cache.go 56.81% <100.00%> (ø)
pkg/skaffold/build/local/types.go 69.44% <100.00%> (ø)
pkg/skaffold/config/options.go 100.00% <100.00%> (ø)
pkg/skaffold/runner/debugging.go 33.33% <100.00%> (ø)
...affold/kubernetes/portforward/kubectl_forwarder.go 65.85% <0.00%> (-2.44%) ⬇️

@dgageot
Change default buildpacks
b2bf1d5 
Signed-off-by: David Gageot <[email protected]>
@dgageot dgageot force-pushed the default-buildpacks branch from babb01b to b2bf1d5 Compare April 30, 2020 10:15
@dgageot dgageot merged commit 24f053e into GoogleContainerTools:master Apr 30, 2020
@fmotrifork fmotrifork mentioned this pull request May 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandealwis briandealwis briandealwis approved these changes

@balopat balopat Awaiting requested review from balopat

@nkubala nkubala Awaiting requested review from nkubala

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees
No one assigned
Labels
cla: yes size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dgageot @briandealwis @googlebot