Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git tagger now supports an optional prefix #4049

Merged
merged 2 commits into from
May 1, 2020
Merged

git tagger now supports an optional prefix #4049

merged 2 commits into from
May 1, 2020

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Apr 29, 2020

Fixes #3816

@codecov
Copy link

codecov bot commented Apr 29, 2020 •
edited
Loading

Codecov Report

Merging #4049 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
pkg/skaffold/schema/latest/config.go 100.00% <ø> (ø)
pkg/skaffold/build/tag/git_commit.go 85.93% <100.00%> (+3.04%) ⬆️
pkg/skaffold/runner/new.go 70.00% <100.00%> (ø)

@balopat balopat merged commit 4ee028b into GoogleContainerTools:master May 1, 2020
@fmotrifork fmotrifork mentioned this pull request May 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balopat balopat balopat approved these changes

@briandealwis briandealwis Awaiting requested review from briandealwis

@nkubala nkubala Awaiting requested review from nkubala

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees
No one assigned
Labels
cla: yes size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for more expressive git commit tags
3 participants
@dgageot @balopat @googlebot