-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print the effective skaffold.yaml configuration #4048
Print the effective skaffold.yaml configuration #4048
Conversation
Codecov Report
|
026a464
to
cb643cf
Compare
Love it, I wanted to open a bug for this :D - this will be super useful for gitops workflows as well, where we can "hydrate" the skaffold config into a separate repo for audit purposes! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional tweaks; I don't feel strongly about them.
cmd/skaffold/app/cmd/diagnose.go
Outdated
WithCommonFlags(). | ||
WithFlags(func(f *pflag.FlagSet) { | ||
f.BoolVar(&onlyConfig, "only-config", false, "Only prints the effective skaffold.yaml configuration") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--only-config
reads oddly. --config-only
or --yaml-only
?
cmd/skaffold/app/cmd/diagnose.go
Outdated
fmt.Fprintln(out, "Skaffold version:", version.Get().GitCommit) | ||
fmt.Fprintln(out, "Configuration version:", config.APIVersion) | ||
fmt.Fprintln(out, "Number of artifacts:", len(config.Build.Artifacts)) | ||
if !onlyConfig { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since YAML supports comments, we could output this as comments?
Signed-off-by: David Gageot <[email protected]>
cb643cf
to
56adaf4
Compare
Example on
examples/nodejs
:Signed-off-by: David Gageot [email protected]