Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent the cache from sending “Build in progress” events. #4038

Merged
merged 2 commits into from
May 4, 2020

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Apr 28, 2020

Only the builder sends “Build in progress” events.
Fixes #3812

Signed-off-by: David Gageot [email protected]

@codecov
Copy link

codecov bot commented Apr 28, 2020

Codecov Report

Merging #4038 into master will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted Files Coverage Δ
pkg/skaffold/build/cache/lookup.go 100.00% <ø> (ø)
pkg/skaffold/build/cache/retrieve.go 69.31% <ø> (-0.35%) ⬇️
pkg/skaffold/runner/deploy.go 60.52% <0.00%> (-3.37%) ⬇️

@dgageot dgageot changed the title Only the builder sends “Build in progress” events. Prevent the cache from sending “Build in progress” events. Apr 28, 2020
@pull-request-size pull-request-size bot added size/M and removed size/S labels Apr 28, 2020
@dgageot dgageot force-pushed the fix-3812 branch 2 times, most recently from 2b9d95b to 4e3cc09 Compare April 28, 2020 14:07
@dgageot
Copy link
Contributor Author

dgageot commented Apr 28, 2020

cc @nkubala

@dgageot dgageot merged commit 756d74c into GoogleContainerTools:master May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

duplicated build events
4 participants