Disable Python detector's use of PYTHON_VERSION #3919
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3918
Description
The Python language runtime detection for
skaffold debug
was blindly accepting any image with thePYTHON_VERSION
environment variable set. Although this does identify an Python-based image, successfully transforming the container requires that the image's entrypoint or command actually invoke thepython
interpreter. So the presence ofPYTHON_VERSION
does not necessarily mean that the image can be transformedUser facing changes (remove if N/A)
Should avoid a possible panic.
Follow-up Work (remove if N/A)
I need to rework the
Apply
interface to remove the possibility of this nil panic.@code128: if you are willing to try this on your insta-puller, you can build a private copy of
skaffold
by runninggo build -o skaffold ./cmd/skaffold/
. Skaffold does require Go 1.14 for building.