Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait for the logs to be printed #3877

Merged
merged 1 commit into from
Mar 27, 2020
Merged

Wait for the logs to be printed #3877

merged 1 commit into from
Mar 27, 2020

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Mar 26, 2020

Previous fix removed the wc.Wait() by error

Signed-off-by: David Gageot [email protected]

@dgageot
Wait for the logs to be printed
c602c59 
Previous fix removed the wc.Wait() by error

Signed-off-by: David Gageot <[email protected]>
@codecov
Copy link

codecov bot commented Mar 26, 2020 •
edited
Loading

Codecov Report

Merging #3877 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted Files Coverage Δ
...affold/kubernetes/portforward/kubectl_forwarder.go 68.29% <0%> (+2.43%) ⬆️

@dgageot
Copy link
Contributor Author

dgageot commented Mar 27, 2020

Minor change. Self merging

@dgageot dgageot merged commit 8e49450 into GoogleContainerTools:master Mar 27, 2020
@fmotrifork fmotrifork mentioned this pull request Apr 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balopat balopat Awaiting requested review from balopat

@nkubala nkubala Awaiting requested review from nkubala

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees
No one assigned
Labels
cla: yes size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dgageot @googlebot