Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update debug-events design proposal status #3874

Merged
merged 1 commit into from
Mar 26, 2020
Merged

Update debug-events design proposal status #3874

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions docs/design_proposals/debug-events.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,11 @@
* Author(s): Brian de Alwis (@briandealwis)
* Design Shepherd: Nick Kubala (@nkubala)
* Date: 2019-10-24
* Status: Reviewed
* Status: *Implemented* (#3609, #3645)
* Related: #2211

Note: implemented but there were some minor name changes.

## Background

Cloud Code for IntelliJ and VS Code currently launch `skaffold debug --port-forward` to start
Expand Down Expand Up @@ -218,4 +220,4 @@ ___
## Integration test plan

Tests will need to verify that pod- and container-start successfully raise debugging _Started_ events,
and container termination and pod-deletion raises _Terminated_ events.
and container termination and pod-deletion raises _Terminated_ events.