Fix skaffold debug panic with nodejs
#3827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briandealwis
requested review from
balopat,
dgageot,
loosebazooka,
nkubala and
tejal29
as code owners
Codecov Report
|
| func rewriteNodeOptions(env map[string]string, spec inspectSpec) []v1.EnvVar { | ||
| found := false | ||
| var vars []v1.EnvVar | ||
| for k, v := range env { |
There was a problem hiding this comment.
can we do something like
nodeOptions = spec.String()
if val, ok := env["NODE_OPTIONS"]; ok {
nodeOptions = v + " " + specString
}
env["NODE_OPTIONS"] = nodeOptions
There was a problem hiding this comment.
oh you have to transform the map...
| @@ -96,8 +96,7 @@ func (t nodeTransformer) Apply(container *v1.Container, config imageConfiguratio | |||
| container.Args = rewriteNpmCommandLine(config.arguments, *spec) | |||
|
|
|||
| default: | |||
| logrus.Warnf("Skipping %q as does not appear to invoke node", container.Name) | |||
| return nil | |||
| container.Env = rewriteNodeOptions(config.env, *spec) | |||
There was a problem hiding this comment.
Just curious, at this point, was there already some hint that this container was node? Could I be a clown and have a java application with a NODE_OPTIONS ?
There was a problem hiding this comment.
you know what never mind, I read the description of the PR... 😞
There was a problem hiding this comment.
It should be unusual (and discouraged) to have a mega-container with both a JVM and NodeJS application. In the k8s sphere, they should be separate containers within the same pod.
dgageot
approved these changes
Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3821
Description
The
nodejsdebug transformer'sIsApplicable()used the presence ofNODE_VERSIONto indicate that the container image is NodeJS-based. But theApply()only handles situations where there is anpmornodeinvocation.User facing changes (remove if N/A)
Look ma, no more panics!
Follow-up Work (remove if N/A)
#2141 must be solved to allow running
examples/nodejsfor example.