[Diagnostics] Add validator interface. Add resource interface and PodValidator #3742

tejal29 · 2020-02-26T23:27:28Z

Relates to #3739

In this PR,

Added a new Validator interface which implements an interface to validate a kubernetes resource.
Added a new Resource interface which describes any kubernetes resource
Added a new PodValidator and modified the existing functions in pod.go to validate pods.

codecov · 2020-02-26T23:41:33Z

Codecov Report

Merging #3742 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted Files	Coverage Δ
cmd/skaffold/app/cmd/flags.go	`100% <0%> (ø)`	⬆️

pkg/diag/validator/resource.go

pkg/diag/validator/validator.go

…implement to Validator interface

tejal29 · 2020-03-03T17:59:45Z

@dgageot Thanks! Please take a look again.

dgageot · 2020-03-04T15:08:59Z

Hey @tejal29 I don't see any changes since my review. All I see are my comments marked as resolved. lol

tejal29 · 2020-03-05T19:06:19Z

Hey @tejal29 I don't see any changes since my review. All I see are my comments marked as resolved. lol

I am so sorry! i didnt realize the push was not successful. Thanks!

tejal29 requested review from balopat, dgageot and nkubala as code owners February 26, 2020 23:27

googlebot added the cla: yes label Feb 26, 2020

pull-request-size bot added the size/L label Feb 26, 2020

tejal29 force-pushed the add_validator branch from 81aafac to b0d31ab Compare February 27, 2020 00:22

dgageot self-assigned this Feb 28, 2020

dgageot suggested changes Feb 28, 2020

View reviewed changes

pkg/diag/validator/resource.go Outdated Show resolved Hide resolved

pkg/diag/validator/validator.go Outdated Show resolved Hide resolved

tejal29 added 2 commits March 3, 2020 09:58

Add validator interface. Add resource interface and change pod.go to …

dfb8f03

…implement to Validator interface

wip

3e9d93a

tejal29 force-pushed the add_validator branch from b0d31ab to 3e9d93a Compare March 5, 2020 19:05

dgageot approved these changes Mar 6, 2020

View reviewed changes

dgageot merged commit 6d20909 into GoogleContainerTools:master Mar 10, 2020

fmotrifork mentioned this pull request Mar 20, 2020

skaffold 1.6.0 fishworks/fish-food#635

Merged

tejal29 deleted the add_validator branch April 15, 2021 07:35