go.mod: upgrade google/go-cmp to v0.4.0 #3698

tstromberg · 2020-02-18T23:32:45Z

go-cmp v0.3.0 suffers panics under go v1.4.x. For more information, see: google/go-cmp#167

Fixes #3697

dgageot

We vendor all the dependencies. Have you run go mod vendor?

codecov · 2020-02-18T23:39:54Z

Codecov Report

Merging #3698 into master will not change coverage.
The diff coverage is n/a.

tstromberg · 2020-02-18T23:49:06Z

Thanks! I had not run go mod vendor. Updated the PR to include the changes to vendor/.

go.mod: upgrade google/go-cmp to v0.4.0 to avoid panic

1244a7a

tstromberg requested review from balopat, dgageot, nkubala and tejal29 as code owners February 18, 2020 23:32

googlebot added the cla: yes label Feb 18, 2020

pull-request-size bot added the size/XS label Feb 18, 2020

tstromberg changed the title ~~go.mod: upgrade google/go-cmp to v0.4.0 to avoid panic~~ go.mod: upgrade google/go-cmp to v0.4.0 Feb 18, 2020

dgageot suggested changes Feb 18, 2020

View reviewed changes

Run 'go mod vendor'

528c2b2

dgageot self-assigned this Feb 18, 2020

dgageot approved these changes Feb 18, 2020

View reviewed changes

dgageot merged commit 6a01959 into master Feb 19, 2020

nkubala deleted the update-go-cmp branch February 19, 2020 19:32