hidden --minikube-profile flag #3691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
dgageot
approved these changes
Feb 16, 2020
cmd/skaffold/app/cmd/flags.go
Outdated
| @@ -261,6 +261,15 @@ var FlagRegistry = []Flag{ | |||
| FlagAddMethod: "StringVar", | |||
| DefinedOn: []string{"build", "debug", "dev", "run"}, | |||
| }, | |||
| { | |||
| Name: "minikube-profile", | |||
| Shorthand: "m", | |||
There was a problem hiding this comment.
nit: Do we really need a shorthand for a hidden flag?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a tactical move until we fix properly #3668.
It adds a hidden --minikube-profile flag that forces skaffold to use the given profile's docker daemon for building, and hence will default to not pushing.
(Apologies for no tests.)