Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the command for switching to getting-started dir after cloning #3574

Merged
merged 2 commits into from
Jan 24, 2020

Conversation

syed-awais-ali
Copy link
Contributor

Relates to in case of new feature, this should point to issue/(s) which describes the feature

Fixes #<issue number>. in case of a bug fix, this should point to a bug and any other related issue(s)

Should merge before : list any PRs that depend on this PR

Should merge after : list any PRs that are prerequisites to this PR

Description

User facing changes

Write n/a if not output or log lines changed and no behavior is changed

Before

If log/output changes: Paste the current relevant skaffold output
If behavior changes: describe succinctly the current behavior

After

If log/output changes: Paste skaffold output after your change
If behavior changes: describe succinctly the behavior after your change

Next PRs.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Mentions any output changes.
  • Adds documentation as needed: user docs, YAML reference, CLI reference.
  • Adds integration tests if needed.

Reviewer Notes

  • The code flow looks good.
  • Unit test added.
  • User facing changes look good.

Release Notes

Examples of user facing changes:
- Skaffold config changes like
  e.g. "Add buildArgs to `Kustomize` deployer skaffold config."
- Bug fixes
  e.g. "Improve skaffold init behavior when tags are used in manifests"
- Any changes in skaffold behavior
  e.g. "Artifact caching is turned on by default."

This fixes the command to change the directory to skaffold/examples/getting-started after cloning from git skaffold repository
update the command for changing directory
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@codecov
Copy link

codecov bot commented Jan 24, 2020

Codecov Report

Merging #3574 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted Files Coverage Δ
...affold/kubernetes/portforward/kubectl_forwarder.go 65.85% <0%> (-2.44%) ⬇️

@syed-awais-ali
Copy link
Contributor Author

@googlebot I signed it

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@dgageot dgageot added the kokoro:run runs the kokoro jobs on a PR label Jan 24, 2020
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Jan 24, 2020
@dgageot dgageot merged commit 374cf77 into GoogleContainerTools:master Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants