Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] There’s no gcsBucket config anymore #3514

Merged
merged 1 commit into from
Jan 16, 2020

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Jan 16, 2020

Signed-off-by: David Gageot [email protected]

@codecov
Copy link

codecov bot commented Jan 16, 2020

Codecov Report

Merging #3514 into master will not change coverage.
The diff coverage is n/a.

@dgageot dgageot force-pushed the gcs-bucket-no-more branch from 2229e5f to 06a1de4 Compare January 16, 2020 08:30
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - hmmm...when did we remove gcsBucket? Did we remove it in a backwards compatible way? It was technically a GA feature, hence we shouldn't remove it before 6 months...

@balopat balopat self-assigned this Jan 16, 2020
@dgageot
Copy link
Contributor Author

dgageot commented Jan 16, 2020

@balopat it's removed in a compatible way. Nothing will fail if people use it, it'll just sync from local files instead.

@dgageot dgageot merged commit 9e20c3e into GoogleContainerTools:master Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants