Enable multiple deployers in skaffold.yaml
#3392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corneliusweig
requested review from
balopat,
dgageot,
nkubala and
tejal29
as code owners
This was referenced Dec 16, 2019
|
I went with the approach to simply drop the deploy:
kubeContext: something
deployers:
- kustomize: {}
- kubectl: {}
- helm: {}
- ...However, the nested |
Codecov Report
|
corneliusweig
changed the title
skaffold.yamlskaffold.yaml
corneliusweig
force-pushed
the
w/deployer-mux/config
branch
from
512a92f to
d746cfc
Compare
This allows re-use by other deployer renderers. Signed-off-by: Cornelius Weig <[email protected]>
This Deployer implemenation forwards commands to all of the deployers in his list. It will be useful to allow multiple deployers in skaffold.yaml. Signed-off-by: Cornelius Weig <[email protected]>
Signed-off-by: Cornelius Weig <[email protected]>
Some use-cases require a hybrid mode where users need to use different deployers at the same time. Signed-off-by: Cornelius Weig <[email protected]>
So far, deployers were marked with `oneOf`, so that only one of them could be active at a time. Since this no longer holds, profile activation now merges the deployers from profiles and base. This change adapts the tests accordingly. Signed-off-by: Cornelius Weig <[email protected]>
This is necessary because the new logic merges profile deployer into the main pipeline instead of replacing existing deployers. Signed-off-by: Cornelius Weig <[email protected]>
Signed-off-by: Cornelius Weig <[email protected]>
Signed-off-by: Cornelius Weig <[email protected]>
corneliusweig
force-pushed
the
w/deployer-mux/config
branch
from
d746cfc to
ec3eaf0
Compare
corneliusweig
changed the title
skaffold.yamlskaffold.yaml
|
I've finally added the missing integration test, so it's no longer WIP :) |
balopat
reviewed
Jan 15, 2020
| @@ -23,7 +23,7 @@ Skaffold supports the following tools for deploying applications: | |||
| The `deploy` section in the Skaffold configuration file, `skaffold.yaml`, | |||
| controls how Skaffold builds artifacts. To use a specific tool for deploying | |||
| artifacts, add the value representing the tool and options for using the tool | |||
| to the `deploy` section. | |||
| to the `deploy` section. You may even use different tools at the same time. | |||
There was a problem hiding this comment.
Suggested change
| to the `deploy` section. You may even use different tools at the same time. | |
| to the `deploy` section. You may even use a combination of each available deployment approach at the same time. |
There was a problem hiding this comment.
I'll not apply this suggestion right now, to not interfere with the kokoro run. But please go ahead and apply this if you think it's ready for merging!
There was a problem hiding this comment.
I just pushed it - will merge as soon as kokoro is done again :)
|
I just rebased it - hope that's fine! |
Yes of course! |
balopat
approved these changes
Jan 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #2875, #3292
Fixes #2875, #3292
Should merge before : n/a
Should merge after : #3391,
#3390Description
Some users find it limiting that they can only configure a single deployer in Skaffold (#2875, #3292). This PR enables using multiple deployers.
User facing changes
Users get the possibility to configure multiple deployers.
Before
skaffold.yamlallows to configure exactly one deployer (kubectl,kustomize,helm).After
Users can configure all three deployers at once. Iow, the
oneOf=deployerconstraint inskaffold.yamlis dropped.Next PRs.
n/a
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Reviewer Notes
Release Notes