Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Cleanup docs #3176

Merged
merged 14 commits into from
Nov 7, 2019
Merged

[docs] Cleanup docs #3176

merged 14 commits into from
Nov 7, 2019

Conversation

balopat
Copy link
Contributor

@balopat balopat commented Nov 5, 2019

  • Talks about Cleanup skaffold delete and the image pruning
  • adds a diagram with all the phases in the workflow page

@balopat balopat added docs-modifications runs the docs preview service on the given PR and removed cla: yes labels Nov 5, 2019
@container-tools-bot
Copy link

Error creating deployment, please see controller logs for details.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Nov 5, 2019
@container-tools-bot
Copy link

Please visit http://35.236.13.246:1313 to view changes to the docs.

@container-tools-bot
Copy link

Error creating deployment, please see controller logs for details.

@tejal29
Copy link
Contributor

tejal29 commented Nov 5, 2019

Looks good!

@codecov
Copy link

codecov bot commented Nov 5, 2019 •
edited
Loading

Codecov Report

Merging #3176 into master will not change coverage.
The diff coverage is n/a.

@tejal29 tejal29 added the priority/p0 Highest priority. We are actively looking at delivering it. label Nov 5, 2019
tejal29
tejal29 reviewed Nov 5, 2019
View reviewed changes
@balopat balopat marked this pull request as ready for review November 6, 2019 05:31
dgageot
dgageot previously requested changes Nov 6, 2019
View reviewed changes
@balopat
Copy link
Contributor Author

balopat commented Nov 6, 2019

Thanks for the review @dgageot :) I'll fix those up!

@balopat balopat requested a review from dgageot November 6, 2019 16:16
@balopat balopat added the docs-modifications runs the docs preview service on the given PR label Nov 6, 2019
@container-tools-bot
Copy link

Please visit http://35.235.117.222:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Nov 6, 2019
tejal29
tejal29 approved these changes Nov 6, 2019
View reviewed changes
Copy link
Contributor

@tejal29 tejal29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

superb!!

nkubala
nkubala reviewed Nov 6, 2019
View reviewed changes
balopat and others added 11 commits November 6, 2019 11:16
@balopat
remove a TODO
8e82d88
@balopat @nkubala
Update docs/content/en/docs/pipeline-stages/cleanup.md
71f8e0b 
Co-Authored-By: Nick Kubala <[email protected]>
@balopat @nkubala
Update docs/content/en/docs/pipeline-stages/cleanup.md
69508f8 
Co-Authored-By: Nick Kubala <[email protected]>
@balopat @nkubala
Update docs/content/en/docs/pipeline-stages/cleanup.md
765b67d 
Co-Authored-By: Nick Kubala <[email protected]>
@balopat @nkubala
Update docs/content/en/docs/pipeline-stages/cleanup.md
8ad82b6 
Co-Authored-By: Nick Kubala <[email protected]>
@balopat @nkubala
Update docs/content/en/docs/pipeline-stages/cleanup.md
2c381da 
Co-Authored-By: Nick Kubala <[email protected]>
@balopat @nkubala
Update docs/content/en/docs/pipeline-stages/cleanup.md
c55fb2a 
Co-Authored-By: Nick Kubala <[email protected]>
@balopat @nkubala
Update docs/data/maturity.json
4d140c5 
Co-Authored-By: Nick Kubala <[email protected]>
@balopat @nkubala
Update docs/content/en/docs/pipeline-stages/cleanup.md
0a3e2de 
Co-Authored-By: Nick Kubala <[email protected]>
@balopat @nkubala
Update docs/content/en/docs/pipeline-stages/cleanup.md
01505c8 
Co-Authored-By: Nick Kubala <[email protected]>
@balopat @nkubala
Update docs/content/en/docs/pipeline-stages/cleanup.md
1419dbf 
Co-Authored-By: Nick Kubala <[email protected]>
@tejal29 tejal29 dismissed dgageot’s stale review November 7, 2019 00:12

addressed changed

@balopat balopat merged commit 4ff6680 into GoogleContainerTools:master Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkubala nkubala nkubala left review comments

@tejal29 tejal29 tejal29 approved these changes

@dgageot dgageot Awaiting requested review from dgageot

Assignees
No one assigned
Labels
cla: yes priority/p0 Highest priority. We are actively looking at delivering it.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@balopat @container-tools-bot @tejal29 @dgageot @nkubala @googlebot