Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skaffold image credits #3146

Merged
merged 5 commits into from
Nov 1, 2019

Conversation

balopat
Copy link
Contributor

@balopat balopat commented Oct 31, 2019

After #3138 is merged.
This adds a /THIRD_PARTY_LICENSES to the gcr.io/k8s-skaffold/skaffold image.
Also vendors the files required by tools so that the build speed is not impacted.

@codecov
Copy link

codecov bot commented Oct 31, 2019

Codecov Report

Merging #3146 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted Files Coverage Δ
cmd/skaffold/app/cmd/credits_dummy.go 0% <ø> (ø) ⬆️
...ck/tools/vendor/github.com/rakyll/statik/statik.go 100% <0%> (ø)

@balopat balopat force-pushed the skaffold_image_credits branch from 633c902 to 45cc3cc Compare October 31, 2019 22:40
@balopat balopat merged commit a9424f7 into GoogleContainerTools:master Nov 1, 2019
@balopat
Copy link
Contributor Author

balopat commented Nov 1, 2019

I merged this myself because it fixes the bug in the previous PR, also because it is high priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants