Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a broken link to the Profiles page #3144

Merged
merged 1 commit into from
Oct 31, 2019

Conversation

peterj
Copy link
Contributor

@peterj peterj commented Oct 31, 2019

Description

Fixes a broken link to the Profiles page

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Mentions any output changes.
  • Adds documentation as needed: user docs, YAML reference, CLI reference.
  • Adds integration tests if needed.

Reviewer Notes

  • The code flow looks good.
  • Unit test added.
  • User facing changes look good.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@peterj
Copy link
Contributor Author

peterj commented Oct 31, 2019

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@codecov
Copy link

codecov bot commented Oct 31, 2019

Codecov Report

Merging #3144 into master will not change coverage.
The diff coverage is n/a.

Impacted Files Coverage Δ
pkg/skaffold/server/server.go 58.57% <0%> (ø) ⬆️

@balopat balopat merged commit 5b17a9b into GoogleContainerTools:master Oct 31, 2019
@balopat
Copy link
Contributor

balopat commented Oct 31, 2019

Thank you!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants