-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare cli-go to accept --kubeconfig
setting
#3107
Merged
tejal29
merged 2 commits into
GoogleContainerTools:master
from
corneliusweig:w/kubeconfig-cli-go
Oct 30, 2019
Merged
Prepare cli-go to accept --kubeconfig
setting
#3107
tejal29
merged 2 commits into
GoogleContainerTools:master
from
corneliusweig:w/kubeconfig-cli-go
Oct 30, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prepares for upcoming commits which introduce the `--kubeconfig` flag.
corneliusweig
requested review from
balopat,
dgageot,
nkubala and
tejal29
as code owners
October 21, 2019 21:48
7 tasks
7 tasks
Codecov Report
|
This introduces yet another global state. An alternative could be to load the kubeconfig eagerly, when ConfigureKubeConfig is called. However, this would require to call this setup method in all tests which make use of the k8s rest client, which is a severe disadvantage. Signed-off-by: Cornelius Weig <[email protected]>
corneliusweig
force-pushed
the
w/kubeconfig-cli-go
branch
from
October 22, 2019 19:49
8683735
to
2790ddf
Compare
tejal29
approved these changes
Oct 23, 2019
The kokoro failure seems unrelated:
|
tejal29
approved these changes
Oct 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #2699
Should merge before : #3100
Should merge after : n/a
Description
This introduces yet another global state in
context.go
. An alternative could be toload the kubeconfig eagerly, when ConfigureKubeConfig is called. However,
this would require to call this setup method in all tests which make use
of the k8s rest client, which is a severe disadvantage.
User facing changes
n/a
Next PRs.
kubectl
andhelm
to accept the--kubeconfig
setting (Prepare kubectl and helm deployers for--kubeconfig
flag #3108 )--kubeconfig
to configure the kubeconfig (Add--kubeconfig
CLI flag to all relevant commands #3100)Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Reviewer Notes