Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close the bracket in documentation #3101

Merged
merged 2 commits into from Oct 23, 2019
Merged

Close the bracket in documentation #3101

merged 2 commits into from Oct 23, 2019

Conversation

ghost
Copy link

@ghost ghost commented Oct 21, 2019

Description

There are small misspell fixes for documentation.
https://skaffold.dev/docs/how-tos/templating/
Screenshot 2019-10-21 at 12 11 53

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Mentions any output changes.
  • Adds documentation as needed: user docs, YAML reference, CLI reference.
  • Adds integration tests if needed.

@ghost ghost requested review from balopat, dgageot, nkubala and tejal29 as code owners October 21, 2019 09:10
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@codecov
Copy link

codecov bot commented Oct 21, 2019

Codecov Report

Merging #3101 into master will not change coverage.
The diff coverage is n/a.

Copy link
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@nkubala
Copy link
Contributor

nkubala commented Oct 21, 2019

@AmetPreply can you check and make sure you signed the CLA, and that your commit was made from the same email address you used to sign it?

@tejal29 tejal29 added the kokoro:run runs the kokoro jobs on a PR label Oct 21, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Oct 21, 2019
@ghost
Copy link
Author

ghost commented Oct 22, 2019

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@tejal29 tejal29 merged commit 20ada24 into GoogleContainerTools:master Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants