Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify debug docs for deprecated Workload APIs #3092

Merged
merged 3 commits into from
Oct 18, 2019
Merged

Clarify debug docs for deprecated Workload APIs #3092

merged 3 commits into from
Oct 18, 2019

Conversation

briandealwis
Copy link
Member

Minor doc modification to expand on debug not handling deprecated workload objects.

@codecov
Copy link

codecov bot commented Oct 18, 2019 •
edited
Loading

Codecov Report

Merging #3092 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted Files Coverage Δ
pkg/skaffold/build/local/custom.go 13.33% <0%> (-6.67%) ⬇️
cmd/skaffold/app/cmd/cmd.go 66.92% <0%> (-1.08%) ⬇️
pkg/skaffold/runner/deploy.go 66.66% <0%> (ø) ⬆️
cmd/skaffold/app/cmd/flags.go 100% <0%> (ø) ⬆️
pkg/skaffold/config/options.go 100% <0%> (ø) ⬆️
pkg/skaffold/runner/build_deploy.go 67.18% <0%> (+0.99%) ⬆️
pkg/skaffold/deploy/status_check.go 55.75% <0%> (+1.97%) ⬆️

tejal29
tejal29 previously approved these changes Oct 18, 2019
View reviewed changes
@tejal29 tejal29 added the docs-modifications runs the docs preview service on the given PR label Oct 18, 2019
@container-tools-bot
Copy link

Please visit http://35.236.79.92:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Oct 18, 2019
@briandealwis
Avoid odd Hugo markdown rendering behaviour with shortcodes:
59b2aa3 
- move _Deprecated Workload API_ into _Limitations_ section
- render other shortcode to HTML
@briandealwis
fix the markdown for realz
39b6f98
@briandealwis
Copy link
Member Author

Unsure why but {{% alert %}} doesn't seem to render the content as markdown. Moved this warning into the Limitations section. Which is where it really belonged.

@briandealwis briandealwis added the docs-modifications runs the docs preview service on the given PR label Oct 18, 2019
@container-tools-bot
Copy link

Please visit http://35.236.1.119:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Oct 18, 2019
@tejal29 tejal29 merged commit b87d90a into GoogleContainerTools:master Oct 18, 2019
@briandealwis briandealwis deleted the debug-deprecations branch November 11, 2019 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tejal29 tejal29 tejal29 approved these changes

@balopat balopat Awaiting requested review from balopat

@dgageot dgageot Awaiting requested review from dgageot

@nkubala nkubala Awaiting requested review from nkubala

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

Assignees
No one assigned
Labels
cla: yes size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@briandealwis @container-tools-bot @tejal29 @googlebot