Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract code that handles graceful termination #3005

Merged
merged 1 commit into from
Oct 7, 2019

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Oct 7, 2019

Just extracting the code for it to be used by other builders.

Signed-off-by: David Gageot [email protected]

@codecov
Copy link

codecov bot commented Oct 7, 2019

Codecov Report

Merging #3005 into master will not change coverage.
The diff coverage is 63.63%.

Impacted Files Coverage Δ
pkg/skaffold/build/custom/custom.go 62.5% <0%> (-1.44%) ⬇️
pkg/skaffold/build/misc/graceful.go 66.66% <66.66%> (ø)

@tejal29 tejal29 merged commit d5fbf51 into GoogleContainerTools:master Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants