Add skip tls verify option to kaniko builder #2976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was able to recreate the error in GoogleContainerTools#1961 by using a kaniko image without a cert & pushing to an unauthenticated registry in Cloud Run. Adding this flag resolves that bug.
priyawadhwa
requested review from
balopat,
dgageot,
nkubala and
tejal29
as code owners
Codecov Report
|
tejal29
requested changes
Oct 3, 2019
tejal29
approved these changes
Oct 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to in case of new feature, this should point to issue/(s) which describes the feature
Should resolve #1961
Description
I was able to recreate the error in #1961 by using a kaniko image
without a cert & pushing to an unauthenticated registry in Cloud Run.
Adding this flag resolves that bug.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
examplesdir, please copy them tointegration/examplesintegration/examplesdir, should be tested in integration testReviewer Notes