Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicate status check #2966

Merged
merged 1 commit into from
Oct 1, 2019
Merged

remove duplicate status check #2966

merged 1 commit into from
Oct 1, 2019

Conversation

tejal29
Copy link
Member

@tejal29 tejal29 commented Oct 1, 2019

Relates to #176
Fixes #2965

Description

User facing changes

n/a

Before

n/a

After
n/a

Next PRs.
n/a

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • [n/a ] Includes unit tests
  • [n/a ] Mentions any output changes.
  • [ n/a] Adds documentation as needed: user docs, YAML reference, CLI reference.
  • [n/a ] Adds integration tests if needed.

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

  • The code flow looks good.
  • Unit test added.
  • User facing changes look good.

Release Notes

@codecov
Copy link

codecov bot commented Oct 1, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@567a080). Click here to learn what that means.
The diff coverage is n/a.

Impacted Files Coverage Δ
pkg/skaffold/event/event.go 92.01% <ø> (ø)

@priyawadhwa priyawadhwa merged commit 66a39a2 into master Oct 1, 2019
@dgageot dgageot deleted the fix_master branch November 6, 2019 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix linter on master
3 participants