Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1beta16 #2955

Merged
merged 3 commits into from
Oct 2, 2019
Merged

v1beta16 #2955

merged 3 commits into from
Oct 2, 2019

Conversation

balopat
Copy link
Contributor

@balopat balopat commented Sep 27, 2019

Adding v1beta16 for new config changes.

@balopat balopat mentioned this pull request Sep 27, 2019
Merged
@codecov
Copy link

codecov bot commented Sep 27, 2019 •
edited
Loading

Codecov Report

Merging #2955 into master will increase coverage by 0.01%.
The diff coverage is 84.61%.

Impacted Files Coverage Δ
pkg/skaffold/schema/versions.go 74.35% <ø> (ø) ⬆️
pkg/skaffold/schema/v1beta14/upgrade.go 77.77% <ø> (ø) ⬆️
pkg/skaffold/schema/latest/config.go 100% <ø> (ø) ⬆️
pkg/skaffold/schema/v1beta15/config.go 100% <100%> (ø)
pkg/skaffold/schema/v1beta15/upgrade.go 77.77% <77.77%> (ø)

@priyawadhwa priyawadhwa added the kokoro:run runs the kokoro jobs on a PR label Oct 2, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Oct 2, 2019
priyawadhwa
priyawadhwa approved these changes Oct 2, 2019
View reviewed changes
Copy link
Contributor

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priyawadhwa priyawadhwa merged commit a4bdbbc into GoogleContainerTools:master Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@priyawadhwa priyawadhwa priyawadhwa approved these changes

@briandealwis briandealwis Awaiting requested review from briandealwis

@chanseokoh chanseokoh Awaiting requested review from chanseokoh

@dgageot dgageot Awaiting requested review from dgageot

@loosebazooka loosebazooka Awaiting requested review from loosebazooka

@nkubala nkubala Awaiting requested review from nkubala

@TadCordle TadCordle Awaiting requested review from TadCordle

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees
No one assigned
Labels
cla: yes size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@balopat @priyawadhwa @googlebot @kokoro-team