Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flake TestGetSetFileValues #2936

Merged
merged 1 commit into from
Sep 24, 2019
Merged

Conversation

tejal29
Copy link
Member

@tejal29 tejal29 commented Sep 24, 2019

Fixes #2935

Description

Sort the array before checking.

 go test github.com/GoogleContainerTools/skaffold/pkg/skaffold/deploy -run TestGetSetFileValues --count=100
ok  	github.com/GoogleContainerTools/skaffold/pkg/skaffold/deploy	0.213s

User facing changes

n/a

Next PRs.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Mentions any output changes.
  • Adds documentation as needed: user docs, YAML reference, CLI reference.
  • Adds integration tests if needed.

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

  • The code flow looks good.
  • Unit test added.
  • User facing changes look good.

Release Notes

Describe any user facing changes here so maintainer can include it in the release notes, or delete this block.

@codecov
Copy link

codecov bot commented Sep 24, 2019

Codecov Report

Merging #2936 into master will not change coverage.
The diff coverage is n/a.

@priyawadhwa priyawadhwa merged commit 8d4135b into GoogleContainerTools:master Sep 24, 2019
@tejal29 tejal29 deleted the 2935 branch April 15, 2021 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flake TestGetSetFileValues
4 participants